[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv4] gethostname: fix build on mingw

From: Eric Blake
Subject: Re: [PATCHv4] gethostname: fix build on mingw
Date: Mon, 22 Mar 2010 12:01:20 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b1 Thunderbird/3.0.3

On 03/22/2010 11:56 AM, Simon Josefsson wrote:
>> Typo on line 26.
> Thanks, now it works.  Any reason not to push this?

Only that I was not set up to reproduce the failure (cross-compiling
from cygwin was running into its own set of problems, because cygwin's
gcc-3 compiler mistakenly picks up cygwin's sys/socket.h instead of
realizing that mingw has no sys/socket.h).  I was relying on a feedback
loop involving testing by Matthias; but your success report also works
for me.  Meanwhile, this thread convinced me to download
i686-pc-mingw32-gcc for Fedora, and I have just barely reproduced the
issue (and the fact that it is fixed) for myself.

So it is now pushed!

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]