[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] glob: synchronize from glibc

From: Eric Blake
Subject: Re: [PATCH 1/3] glob: synchronize from glibc
Date: Tue, 23 Mar 2010 07:55:37 -0600
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100301 Fedora/3.0.3-1.fc12 Lightning/1.0b1 Thunderbird/3.0.3

On 03/23/2010 01:34 AM, Bert Wesarg wrote:
>> +       * lib/glob.c (glob): Lose register modifier.  Drop redundant
>> +       code.
>>  glob (pattern, flags, errfunc, pglob)
>> -     const char * restrict pattern;
>> +     const char *pattern;
> Thats 'restrict' not 'register'.

Hmm.  I wasn't reading that very well, then.  The change would
synchronize gnulib and glibc (since glibc also lacks the restrict
modifier), but keeping the modifier might help the compiler, and is
certainly more POSIX compliant.  On the other hand, the fact that the
declaration is still K&R style makes me cringe, but again it is a matter
of glibc synchronization.  I think I'll just revert this part of the hunk.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]