[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Simon Josefsson
Subject: sc_Wundef_boolean
Date: Wed, 24 Mar 2010 09:56:52 +0100
User-agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)

This syntax-check warning appears to fail:

address@hidden:~/src/libidn master$ make sc_Wundef_boolean
grep: : No such file or directory
address@hidden:~/src/libidn master$ 

Any reason we can't use the normal VC_LIST_EXCEPT instead?  It will
check more files than just config.h.  Alternatively, use VC_LIST_EXCEPT
as a fall back if CONFIG_INCLUDE is not available, which happens when
autoreconf/configure haven't been run yet.


diff --git a/top/maint.mk b/top/maint.mk
index 67421f2..12d0d6a 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -766,7 +766,7 @@ sc_copyright_check:
 # tests many undefined macros, and so we can't enable that option.
 # So at least preclude common boolean strings as macro values.
-       @grep -Ei '^#define.*(yes|no|true|false)$$' '$(CONFIG_INCLUDE)' && \
+       @grep -Ei '^#define.*(yes|no|true|false)$$' $$($(VC_LIST_EXCEPT)) && \
          { echo 'Use 0 or 1 for macro values' 1>&2; exit 1; } || :

reply via email to

[Prev in Thread] Current Thread [Next in Thread]