[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] maint: use pragma consistently across replacement header

From: Jim Meyering
Subject: Re: [PATCH 2/2] maint: use pragma consistently across replacement headers
Date: Tue, 30 Mar 2010 17:37:04 +0200

Bruno Haible wrote:
> Hi Eric,
>> but for the remaining files, we might as
>> well satisfy gcc's optimization, since the effort is trivial.
>> Please apply.
> Applied.
>> Hmm, if we were using cppi more religiously, I wouldn't have introduced
>> the whitespace usage in that #if in the first place.
> The file lib/time.in.h is intended according to cppi, and I find it quite
> unesthetic.

Some of us have mixed feelings about cpp indentation in .h files,
since those often have file-spanning #if*...#endif blocks.
Especially when they're more than a few lines long.

If someone wants to teach cppi about this preference
by making it start with an initial indentation level of "-1",
that should do the trick.

Then you can remove this item from TODO:

    Add an option to enable the following (there's already support for it):
      Uli's suggestion for setting initial indentation level to e.g. -1
      for header files bracketed with #ifdef FOO_H/#define FOO_H...#endif.

It might even be useful to permit either indentation style
in .h files, as long as the style is consistent for each file.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]