[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
error: don't use overridden fcntl
From: |
Bruno Haible |
Subject: |
error: don't use overridden fcntl |
Date: |
Sun, 9 May 2010 12:16:20 +0200 |
User-agent: |
KMail/1.9.9 |
The error module does not need the gnulib module 'fcntl' (it only uses F_GETFL,
for which rpl_fcntl provides no advantage, see doc/posix-functions/fcntl.texi).
Therefore, even if fcntl is overridden, it does not need to call that override.
I'm applying the patch below. It avoids an error in gettext:
./.libs/libgnu.a(error.o): In function `libgettextpo_error':
/home/bruno/gettext-0.18-cygwin15/gettext-tools/libgettextpo/error.c:127:
undefined reference to `_rpl_fcntl'
./.libs/libgnu.a(error.o): In function `libgettextpo_error_at_line':
/home/bruno/gettext-0.18-cygwin15/gettext-tools/libgettextpo/error.c:127:
undefined reference to `_rpl_fcntl'
Creating library file: .libs/libgettextpo.dll.a
collect2: ld returned 1 exit status
make[3]: *** [libgettextpo.la] Error 1
This error occurs because gettext-tools/gnulib-lib/ uses the fcntl module
(implicitly, as a dependency of 'execute') and gettext-tools/libgettextpo/
doesn't. But both share the same fcntl.h file.
2010-05-09 Bruno Haible <address@hidden>
error: Use system's fcntl function.
* lib/error.c (fcntl): Undefine.
--- lib/error.c.orig Sun May 9 12:14:43 2010
+++ lib/error.c Sun May 9 12:06:08 2010
@@ -94,6 +94,9 @@
# include <windows.h>
# endif
+/* The gnulib override of fcntl is not needed in this file. */
+# undef fcntl
+
# if !HAVE_DECL_STRERROR_R && STRERROR_R_CHAR_P
# ifndef HAVE_DECL_STRERROR_R
"this configure-time declaration test was not run"
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- error: don't use overridden fcntl,
Bruno Haible <=