[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] inttostr: add a new function, inttostr
From: |
Bruno Haible |
Subject: |
Re: [PATCH] inttostr: add a new function, inttostr |
Date: |
Wed, 9 Jun 2010 23:24:38 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Jim,
> --- a/modules/inttostr
> +++ b/modules/inttostr
> @@ -2,6 +2,7 @@ Description:
> Convert integers to printable strings.
>
> Files:
> +lib/anytostr.c
> lib/imaxtostr.c
> lib/inttostr.c
> lib/inttostr.h
This is not complete. You also need to tell Automake to compile the inttostr.c
file, either through a
lib_SOURCES += inttostr.c
line in the module description, or in m4/inttostr.m4.
Since we have seen (last time a week ago) how limited AC_LIBOBJ is in general,
I would suggest to convert the 4 AC_LIBOBJ invocations to a lib_SOURCES
augmentation, like this:
--- m4/inttostr.m4.orig Wed Jun 9 23:23:20 2010
+++ m4/inttostr.m4 Wed Jun 9 23:22:25 2010
@@ -1,4 +1,4 @@
-#serial 7
+#serial 8
dnl Copyright (C) 2004, 2005, 2006, 2009, 2010 Free Software Foundation, Inc.
dnl This file is free software; the Free Software Foundation
dnl gives unlimited permission to copy and/or distribute it,
@@ -6,11 +6,6 @@
AC_DEFUN([gl_INTTOSTR],
[
- AC_LIBOBJ([imaxtostr])
- AC_LIBOBJ([offtostr])
- AC_LIBOBJ([umaxtostr])
- AC_LIBOBJ([uinttostr])
-
gl_PREREQ_INTTOSTR
gl_PREREQ_IMAXTOSTR
gl_PREREQ_OFFTOSTR
--- modules/inttostr.orig Wed Jun 9 23:23:20 2010
+++ modules/inttostr Wed Jun 9 23:23:09 2010
@@ -19,6 +19,7 @@
gl_INTTOSTR
Makefile.am:
+lib_SOURCES += imaxtostr.c offtostr.c umaxtostr.c uinttostr.c
Include:
"inttostr.h"