[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

false negative in maint.mk

From: Eric Blake
Subject: false negative in maint.mk
Date: Thu, 29 Jul 2010 08:07:57 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100720 Fedora/3.1.1-1.fc13 Lightning/1.0b2pre Mnenhy/0.8.3 Thunderbird/3.1.1

I just updated m4 to the latest gnulib, and it fails 'make syntax-check':

maint.mk: out of date copyright in doc/m4.texi; update it
make: *** [sc_copyright_check] Error 1

Two bugs here:

First, m4.texinfo contains:

Copyright @copyright{} 1989, 1990, 1991, 1992, 1993, 1994, 2004, 2005,
2006, 2007, 2008, 2009, 2010 Free Software Foundation, Inc.

Therefore, using the single-line checking of $(_sc_search_regexp) in
sc_copyright_check is doomed to false failures.

Second, notice that the file is named m4.texinfo, but the test is
hard-wired to only print an error for m4.texi.  Use of in_vc_files still
selects the longer spelling, because texi as a regular expression
matches texinfo, but it would be better to use the same approach as
sc_texinfo_acronym, as well as checking more than just $(PACKAGE).texi.

However, I'm not sure how best to rewrite the rule for multi-line
copyrights, so for now, I'm just skipping that check in m4.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]