[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: readlink on AIX 7.1BETA

From: Bruno Haible
Subject: Re: readlink on AIX 7.1BETA
Date: Sat, 31 Jul 2010 12:23:34 +0200
User-agent: KMail/1.9.9

Eric Blake wrote:
> Is readlink already being replaced due to other bugs?  (I guess I need
> to look more closely at your logs.)

It is not being replaced:


> If so, then I think the replacement
> should work around this.  If not, I'm perfectly fine relaxing the test
> (there's already a number of places where we can't guarantee the same
> errno as required by POSIX without lots of bloat; as long as a
> reasonable error happens, it's generally okay for a looser test).

OK, I'm applying this:

2010-07-31  Bruno Haible  <address@hidden>

        readlink: Relax test a bit.
        * tests/test-readlink.h (test_readlink): Allow different errno value
        when readlink is called with a file name that ends in / and refers to
        a file.
        Suggested by Eric Blake.
        Reported by Rainer Tammer.

--- tests/test-readlink.h.orig  Sat Jul 31 12:21:12 2010
+++ tests/test-readlink.h       Sat Jul 31 12:20:44 2010
@@ -51,7 +51,7 @@
   ASSERT (errno == EINVAL);
   errno = 0;
   ASSERT (func (BASE "file/", buf, sizeof buf) == -1);
-  ASSERT (errno == ENOTDIR);
+  ASSERT (errno == ENOTDIR || errno == EINVAL); /* AIX yields EINVAL */
   /* Now test actual symlinks.  */
   if (symlink (BASE "dir", BASE "link"))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]