Re: [PATCH] getdate: rename to get_date

[Bruno Haible]

Eric Blake wrote:
> I went with get_date, and not Bruno's parse-datetime.  Afterall,
> parse-duration supplies the parse_duration function, and
> get_date supplies the get_date function.

Well, my suggestion implied to rename the function as well, not
only the module :-)

>  lib/{getdate.y => get_date.y}             |    0
>  m4/{getdate.m4 => get_date.m4}            |    4 +-

I find it good to also rename getdate.texi to get_date.texi.
Otherwise we continue to have two files doc/getdate.texi
and doc/posix-functions/getdate.texi, which is still confusing.
Yes, packages that include this documentation in their manual
need a one-liner change in their main .texi file. The NEWS file
says it:


2010-09-30  Bruno Haible  <address@hidden>

        More renaming from 'getdate' to 'get_date'.
        * doc/get_date.texi: Renamed from doc/getdate.texi.
        * modules/get_date (Files): Update.
        * MODULES.html.sh (Date and time <time.h>): Update.
        * DEPENDENCIES: Update.
        * gnulib-tool: Update comment.
        * m4/bison.m4 (gl_BISON): Likewise.
        * m4/get_date.m4 (gl_GET_DATE): Likewise.

--- DEPENDENCIES.orig   Thu Sep 30 23:28:40 2010
+++ DEPENDENCIES        Thu Sep 30 23:17:14 2010
@@ -101,7 +101,7 @@
 
 * Bison 2.0 or newer.
   + Recommended.
-    Needed if you use the 'getdate' module.
+    Needed if you use the 'get_date' module.
   + Homepage:
     http://www.gnu.org/software/bison/
   + Download:
--- MODULES.html.sh.orig        Thu Sep 30 23:28:40 2010
+++ MODULES.html.sh     Thu Sep 30 23:17:37 2010
@@ -1835,7 +1835,7 @@
   func_echo "$element"
 
   func_begin_table
-  func_module getdate
+  func_module get_date
   func_module timegm
   func_module tzset
   func_end_table
--- NEWS.orig   Thu Sep 30 23:28:40 2010
+++ NEWS        Thu Sep 30 23:28:34 2010
@@ -14,7 +14,8 @@
 
 2010-09-30  getdate         This module is deprecated. Please use get_date
                             for get_date(), or help us write getdate-posix
-                            for getdate().
+                            for getdate(). Also, doc/getdate.texi has been
+                            renamed to doc/get_date.texi.
 
 2010-09-29  sys_wait        This module no longer provides the waitpid()
                             function. If you need this function, you now need
--- doc/get_date.texi.orig      Thu Sep 30 23:28:40 2010
+++ doc/get_date.texi   Thu Sep 30 23:18:45 2010
@@ -552,5 +552,5 @@
 @cindex Pinard, F.
 @cindex Berry, K.
 This chapter was originally produced by Fran@,{c}ois Pinard
-(@email{pinard@@iro.umontreal.ca}) from the @file{getdate.y} source code,
+(@email{pinard@@iro.umontreal.ca}) from the @file{get_date.y} source code,
 and then edited by K.@: Berry (@email{kb@@cs.umb.edu}).
--- gnulib-tool.orig    Thu Sep 30 23:28:40 2010
+++ gnulib-tool Thu Sep 30 23:19:29 2010
@@ -5324,7 +5324,7 @@
     ) || func_exit 1
   fi
   # Need to run configure and make once, to create built files that are to be
-  # distributed (such as getdate.c).
+  # distributed (such as get_date.c).
   sed_remove_make_variables='s,[$]([A-Za-z0-9_]*),,g'
   # Extract the value of "CLEANFILES += ..." and "MOSTLYCLEANFILES += ...".
   cleaned_files=`sed -e "$sed_remove_backslash_newline" < 
"$testdir/$sourcebase/Makefile.am" \
--- m4/bison.m4.orig    Thu Sep 30 23:28:40 2010
+++ m4/bison.m4 Thu Sep 30 23:19:51 2010
@@ -1,4 +1,4 @@
-# serial 5
+# serial 6
 
 # Copyright (C) 2002, 2005, 2009, 2010 Free Software Foundation, Inc.
 # This file is free software; the Free Software Foundation
@@ -7,7 +7,7 @@
 
 AC_DEFUN([gl_BISON],
 [
-  # getdate.y works with bison only.
+  # get_date.y works with bison only.
   : ${YACC='bison -y'}
 dnl
 dnl Declaring YACC & YFLAGS precious will not be necessary after GNULIB
--- m4/get_date.m4.orig Thu Sep 30 23:28:40 2010
+++ m4/get_date.m4      Thu Sep 30 23:20:09 2010
@@ -1,4 +1,4 @@
-# getdate.m4 serial 17
+# get_date.m4 serial 17
 dnl Copyright (C) 2002-2006, 2008-2010 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -30,7 +30,7 @@
   AC_REQUIRE([AM_STDBOOL_H])
   AC_REQUIRE([gl_TIMESPEC])
 
-  dnl Prerequisites of lib/getdate.y.
+  dnl Prerequisites of lib/get_date.y.
   AC_REQUIRE([gl_BISON])
   AC_REQUIRE([gl_C_COMPOUND_LITERALS])
   AC_STRUCT_TIMEZONE
--- modules/get_date.orig       Thu Sep 30 23:28:40 2010
+++ modules/get_date    Thu Sep 30 23:22:14 2010
@@ -2,7 +2,7 @@
 Convert a date/time string to linear time.
 
 Files:
-doc/getdate.texi
+doc/get_date.texi
 lib/getdate.h
 lib/get_date.y
 m4/bison.m4