[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] inttostr: simplify by removing unnecessary redundancy

From: Paul Eggert
Subject: Re: [PATCH] inttostr: simplify by removing unnecessary redundancy
Date: Fri, 22 Oct 2010 13:12:13 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20101006 Thunderbird/3.0.9

On 10/22/10 12:58, Jim Meyering wrote:
> Toeing the line in this case is counterproductive.
> How about sticking with your improvement and instead
> using this pragma in that file?
> # pragma GCC diagnostic ignored "-Wtype-limits"

Hmm, Eric removed that line about a year ago,
complaining that it didn't work for older GCC.  See:


Eric, is it OK for us to put this back in now?  I guess the
price will be noisy compiles for people who use
older gcc versions and -Wtype-limits.  For which our response
would be "either upgrade GCC, or don't use -Wtype-limits".

It's not a big deal either way, obviously.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]