Re: [PATCH] renameat: port to Solaris 10, which declares renameat in unistd.h

[Eric Blake]

On 10/26/2010 05:15 PM, Bruno Haible wrote:
> Yes, but we can limit the damage to Solaris systems and to packages that use
> the 'renameat' module. Like we do in lib/string.in.h for example.
>
> Here's a proposed patch. I verified that it fixes the compilation error
> mentioned above. It also mentions the Solaris problem in the documentation
> (like we do for all portability problems, regardless whether we add a
> workaround to gnulib).

I concur with the idea of this patch, but wonder if we need to tighten 
up lib/unistd.in.h to only include <stdio.h> on Cygwin, so as to avoid 
difficult analysis of whether the circular inclusions between our 
replacement <stdio.h> and <unistd.h> would negatively affect Solaris 10.

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org