[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libvirt] [PATCH] show compiled in options in virsh --version

From: Jim Meyering
Subject: Re: [libvirt] [PATCH] show compiled in options in virsh --version
Date: Thu, 28 Oct 2010 21:53:13 +0200

Eric Blake wrote:
> [adding bug-gnulib]
> On 10/28/2010 01:25 PM, Daniel Veillard wrote:
>>>>          case 'v':
>>>> -            /* FIXME - list a copyright blurb, as in GNU programs?  */
>>>> -            puts(VERSION);
>>>> +            vshShowVersion(ctl);
>>>>              exit(EXIT_SUCCESS);
>>> Pre-existing bug - we don't detect write failure to stdout to exit with
>>> non-zero status.  Unchanged by your patch.
>>   Not sure it's really a problem, but okay I will look.
> The gnulib module closeout can automatically take care of this, but it
> is currently licensed as GPL.  Jim, Bruno, are you okay with relicensing
> closeout and close-stream as LGPLv2+?

They're both relatively thin wrappers.
Fine by me.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]