[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [unigbrk 1/2] unigbrk: Fix uc_graphemeclusterbreak_property(), add c
From: |
Bruno Haible |
Subject: |
Re: [unigbrk 1/2] unigbrk: Fix uc_graphemeclusterbreak_property(), add comprehensive test. |
Date: |
Sat, 1 Jan 2011 13:53:35 +0100 |
User-agent: |
KMail/1.9.9 |
Hi Ben,
> +++ b/tests/unigbrk/test-uc-gbrk-prop.c
> ...
> + fprintf (stderr, "uc_graphemeclusterbreak_property(%#x) "
> + "yielded %s but should have been %s\n",
> + uc, graphemebreakproperty_to_string (retval),
> + graphemebreakproperty_to_string (r->gbp));
> + abort ();
> + }
> + }
> + }
> + ASSERT (uc == 0x110000);
> +
> + return 0;
> +}
Here it would be good to insert an
fflush (stderr);
statement between the fprintf and the abort statements. Reason: On mingw,
stdio buffers are not flushed when abort() is called, i.e. their contents
gets lost.
Otherwise perfect, please push this one.
Bruno
- Re: [unigbrk 1/2] unigbrk: Fix uc_graphemeclusterbreak_property(), add comprehensive test.,
Bruno Haible <=