[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libvirt] [PATCH] Imprint all logs with version + package build info

From: Eric Blake
Subject: Re: [libvirt] [PATCH] Imprint all logs with version + package build information
Date: Thu, 27 Jan 2011 13:23:41 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

[adding bug-gnulib]

On 01/27/2011 11:21 AM, Daniel P. Berrange wrote:
> The logging functions are enhanced so that immediately prior to
> the first log message being printed to any output channel, the
> libvirt package version will be printed.
> eg
>  $ LIBVIRT_DEBUG=1 virsh
>  18:13:28.013: 17536: info : libvirt version: 0.8.7
>  18:13:28.013: 17536: debug : virInitialize:361 : register drivers

I like it.

> * src/util/logging.c: Output version data prior to first log message
> * libvirt.spec.in: Include RPM release, date, hostname & packager
> * configure.ac: Add --with-package-string arg

Let's have some cross-project compatibility (to avoid confusion or
subtle typos when using the same option already in use elsewhere).  Many
GNU projects already have the following configure options:

  --with-packager         String identifying the packager of this software
  --with-packager-version Packager-specific version information
                          Packager info for bug reports (URL/e-mail/...)

and in fact, they get that straight out of gnulib, via the version-etc
module (unfortunately LGPLv3+ at the moment) - let me see if I can get
that improved, so we can reap the benefits of shared code, before I
review a slightly different implementation for libvirt.  But part of the
issue is that the current version-etc module, in addition to providing
the nice .m4 file for defining additional PACKAGER variables in the
source code, also provides the version_etc() function which is hardcoded
to output a GPLv3+ version string (oops - why is the module LGPLv3+ if
it outputs GPLv3+?).

Gnulib already has version-etc-fsf separate from version-etc for easy
exclusion of an FSF copyright holder, so what is still missing is an
easy way to override the default license output when using
version_etc().  Maybe by moving the default GPLv3+ out of version-etc.c
and into version-etc-fsf.c.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]