[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint.mk: suppress a syntax check false positive

From: Eric Blake
Subject: Re: [PATCH] maint.mk: suppress a syntax check false positive
Date: Fri, 11 Mar 2011 06:50:13 -0700
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 03/11/2011 02:32 AM, Jim Meyering wrote:
> Pádraig Brady wrote:
>> A recent change to dd in coreutils triggered this issue,
>> which is avoided with the attached.
>>  sc_unmarked_diagnostics:
>>      @grep -nE                                                       \
>>          '\<error *\([^"]*"[^"]*[a-z]{3}' $$($(VC_LIST_EXCEPT))      \
>> -      | grep -v '_''(' &&                                           \
>> +      | grep -Ev '(_|ngettext )\(' &&                               \

Don't we recommend the use of N_() rather than spelling out ngettext ()?

> Then wondered if we should be more permissive in what we filter out,
> perhaps by allowing 0 or more spaces between ngettext and the following "(":
>         | grep -Ev '(_|ngettext *)\(' &&                              \

If we're going to look for raw ngettext, why not also look for raw
gettext, or even d?c?n?gettext?

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]