[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: VC-tag again

From: Eric Blake
Subject: Re: VC-tag again
Date: Mon, 14 Mar 2011 09:43:00 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7

On 03/14/2011 09:35 AM, Reuben Thomas wrote:
> This line in maint.mk:
> VC-tag = git tag -s -m '$(VERSION)' -u '$(gpg_key_ID)'
> does appear to be unused, because its syntax is wrong: there's no
> message (argument to -m), or equivalently, no tag name is specified.

Actually, the message _is_ $(VERSION).  Rather, it looks like this is
missing a tag name, which should be v$(VERSION) (that is, coreutils 8.10
was tagged as v8.10).

> Is something like:
> VC-tag = git tag -s -m 'Sign version $(VERSION)' '$(VERSION)' -u 
> '$(gpg_key_ID)'
> intended?

Lately, Jim uses the build-aux/do-release-commit-and-tag script for this
instead of a maint.mk makefile rule, which is probably why it isn't very
well tested.  Maybe it's worth removing this as cruft and instead
encouraging the use of do-release-commit-and-tag in more places?  That
script also drops the -u argument, on the grounds that you have probably
configured 'git config user.signingkey ...' correctly in the first
place.  It basically uses:

git tag -s -m '$(PACKAGE) $(VERSION)' v$(VERSION)

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]