[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bootstrap: compute gnulib_extra_files after updating build_a

From: Eric Blake
Subject: Re: [PATCH] bootstrap: compute gnulib_extra_files after updating build_aux
Date: Tue, 05 Apr 2011 14:47:09 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9

On 04/05/2011 02:43 PM, Bruce Korb wrote:
> * build-aux/bootstrap (gnulib_extra_files): bootstrap.conf may
> change build_aux or also supply gnulib_extra_files.  Handle correctly.

> +# Extra files from gnulib, which override files from other sources.
> +test -z "${gnulib_extra_files}" && \

I'm not a fan of extra {} when they are not syntactically necessary
(test -z "$gnulib_extra_files" would work just as well), but I'm not
heart-broken if you commit it as-is.

Other than that, looks good to me.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]