[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv2 5/9] dirent-safer: drop unused link dependency

From: Eric Blake
Subject: Re: [PATCHv2 5/9] dirent-safer: drop unused link dependency
Date: Tue, 26 Apr 2011 21:04:15 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9

On 04/26/2011 07:28 PM, Eric Blake wrote:
> On 04/26/2011 05:35 PM, Eric Blake wrote:
>> Ever since commit 2392b18099, fdopendir no longer drags in xalloc-die
>> through indirect dependencies, so this test no longer needs $(LIBINTL).
>> * modules/dirent-safer-tests (Makefile.am): Drop stale LDADD.
> NAK to this patch (but that doesn't affect the other 8 in the series).

Actually, this works, but fdopendir-tests, and possibly a few others,
should also drop LDADD.

> In isolation, test-dirent-safer doesn't use fdopendir; but with
> dirent-safer and fdopendir used at the same time, then xalloc is still
> being pulled in.  That is, commit 2392b18 dropped xalloc-die for openat,
> but fdopendir is using more than openat and still dragging in xalloc
> through some other path.
> [Hmm, './gnulib-tool --test openat' excludes xalloc-die, but
> './gnulib-tool --test --with-tests openat' pulls it in - I'm still
> investigating...]

Found it.  mgetgroups is pulling in xalloc for the xgetgroups()
function, when the two should really be separated into two different
modules and only xgetgroups pull in xalloc.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]