[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] tests: drop unused link dependency

From: Jim Meyering
Subject: Re: [PATCH 2/2] tests: drop unused link dependency
Date: Wed, 27 Apr 2011 08:24:17 +0200

Eric Blake wrote:
> Ever since commit 2392b18099, openat and fdopendir no longer drag in
> xalloc-die through indirect dependencies, so these tests no longer
> need $(LIBINTL).
> * modules/areadlinkat-tests (Makefile.am): Drop stale LDADD.
> * modules/dirent-safer-tests (Makefile.am): Likewise.
> * modules/fdopendir-tests (Makefile.am): Likewise.
> * modules/hash-tests (Makefile.am): Likewise.
> * modules/linkat-tests (Makefile.am): Likewise.
> * modules/mkfifoat-tests (Makefile.am): Likewise.
> * modules/openat-safer-tests (Makefile.am): Likewise.
> * modules/openat-tests (Makefile.am): Likewise.
> * modules/readlinkat-tests (Makefile.am): Likewise.
> * modules/symlinkat-tests (Makefile.am): Likewise.
> * modules/fdutimensat-tests (test_fdutimensat_LDADD): Drop unused
> * modules/utimensat-tests (test_utimensat_LDADD): Likewise.
> * tests/test-hash.c: Drop unused include.
> Signed-off-by: Eric Blake <address@hidden>
> ---
> fdutimensat-tests still pulls in xalloc, via utimecmp (which
> calls xalloc_die if it can't manage a hash table).  So this
> patch isn't quite perfect yet, but getting closer.  Any ideas
> on whether it would be possible to make utimecmp work without
> xalloc?

Looks feasible.
The hash table is solely to avoid incurring the cost of calculating
the time stamp resolution for every call.  The alternative is simply
to incur the cost when hash table initialization or insertion fails.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]