[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fatal-signal: silence coverity warning

From: Pádraig Brady
Subject: Re: [PATCH] fatal-signal: silence coverity warning
Date: Sat, 30 Apr 2011 10:52:03 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20100227 Thunderbird/3.0.3

On 30/04/11 00:26, Eric Blake wrote:
> Looks nice from my reading of it.  Although for the cache variable
> names, should we go with gl_cv_cc_nomfi_supported rather than
> gl_cv_nomfi_supported (that is, add cc_ to each of the cache variable
> names), to make it clear that the cache variables are all related to CC
> characteristics?  (Compare how we use cv_func, cv_decl, and other such
> namespace designators, and cv_nomfi isn't really a namespace).

I've amended that, and the indenting issue Bruno noticed, and pushed.

thanks guys,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]