[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: git-version-gen and EXTRA_DIST

From: Eric Blake
Subject: Re: git-version-gen and EXTRA_DIST
Date: Sat, 30 Apr 2011 10:25:21 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.9

On 04/30/2011 09:53 AM, Simon Josefsson wrote:
> I got a report [1] that it wasn't possible to run 'autoreconf' in a
> distribution tarball because build-aux/git-version-gen was not
> distributed.  Is this intended to work automatically somehow?
> Otherwise, how about this patch?
> /Simon
> [1] 
> http://lists.nongnu.org/archive/html/oath-toolkit-help/2011-04/msg00039.html
> diff --git a/modules/git-version-gen b/modules/git-version-gen
> index a783ac5..e42dff0 100644
> --- a/modules/git-version-gen
> +++ b/modules/git-version-gen
> @@ -1,6 +1,9 @@
>  Description:
>  Compute a version string from a git repository.
> +Notice:
> +You must add EXTRA_DIST += build-aux/git-version-gen to Makefile.am.

Even better would be to put the EXTRA_DIST line under the configure.ac
portion of the module file.  There are probably other modules, like
gnupload, that could also benefit from that sort of treatment.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]