[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: do-release-commit-and-tag requires that I be on master branch?

From: Jim Meyering
Subject: Re: do-release-commit-and-tag requires that I be on master branch?
Date: Wed, 04 May 2011 13:56:13 +0200

Reuben Thomas wrote:
> On 4 May 2011 09:34, Jim Meyering <address@hidden> wrote:
>> Reuben Thomas wrote:
>>>> For now, I'd just comment out the test so you can make your release.
>>>> Then, maybe add an option to accomplish the same thing.
>>> Such as providing the correct branch name as an argument?
>> Sure.
> Patch attached.

Thanks.  Applied with the one-line summary adjusted to
start with the name of the affected file/module.

BTW, please make your patches in-line, or at least make
the type be text or x-patch rather than "octet-stream".
Here, we prefer not to have to take extra measures (not even
to click on a button/link) to see a patch.

In case you're inclined, a couple of desirable but don't-really-matter
changes: allow an "=", i.e. --branch=BR
and accept abbreviations like --b=BR or --br=BR.

> From 7279461ca3f905956d584ecc8ce4a356a60fa85a Mon Sep 17 00:00:00 2001
> From: Reuben Thomas <address@hidden>
> Date: Wed, 4 May 2011 12:22:12 +0100
> Subject: [PATCH] Add option to do-release-commit-and-tag to specify branch.
> * build-aux/do-release-commit-and-tag: Add --branch.
> ---
>  ChangeLog                           |    5 +++++
>  build-aux/do-release-commit-and-tag |   20 +++++++++++++-------
>  2 files changed, 18 insertions(+), 7 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]