[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] maint: remove useless REPLACE_*_H macros

From: Eric Blake
Subject: Re: [PATCH 1/2] maint: remove useless REPLACE_*_H macros
Date: Thu, 05 May 2011 08:22:39 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10

On 05/05/2011 03:20 AM, Bruno Haible wrote:
> Hi Eric,
>> There are still a few modules, like iconv_h.m4, that still
>> use older paradigms where GNULIB_POSIXCHECK is unsupported
>> and where gl_REPLACE_<HEADER>_H is still essential.  But since
>> we are moving away from that style, I see no reason to keep
>> the idiom for the modules that don't need it.
> I agree. Replacing the headers unconditionally is stable enough by now.
> It's unlikely that we will switch back to the older idiom.
> This patch 1/2 is fine.

Thanks; I've pushed it.

> PATCH 2/2 looks wrong, though. More on this in a separate mail.

Yes, your ideas for an improved idiom look sane.

Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]