[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Enable more syntax checks, eliminate useless C preproces
From: |
Eric Blake |
Subject: |
Re: [PATCH 1/2] Enable more syntax checks, eliminate useless C preprocessor parentheses |
Date: |
Mon, 13 Jun 2011 17:49:00 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.10 |
[redirecting to bug-gnulib]
On 06/13/2011 05:27 PM, James Youngman wrote:
> On Mon, Jun 13, 2011 at 4:28 PM, Eric Blake <address@hidden> wrote:
>> On 06/11/2011 07:42 PM, James Youngman wrote:
>>> +++ b/find/find.c
> [...]
>
> Thanks for these comments. They're addressed in the patch "Assume
> SIGCHLD and O_NOFOLLOW are defined by gnulib" which I just mailed.
>
>> Gnulib should be taking care of that for you. I know that mingw still
>> lacks SIGCHLD (of any spelling), but are there any modern systems that
>> lack SIGCHLD but have SIGCLD?
>
> I know of none.
Widening the question: we're trying to get rid of a findutils construct:
-#if defined SIGCLD && !defined SIGCHLD
-# define SIGCHLD SIGCLD
-#endif
and need to know if gnulib's replacement <signal.h> needs to guarantee
this definition of SIGCHLD, or if the only platforms where only SIGCLD
existed are now so old to not be worth worrying about.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 1/2] Enable more syntax checks, eliminate useless C preprocessor parentheses,
Eric Blake <=