[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check
From: |
Bruno Haible |
Subject: |
Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check this |
Date: |
Mon, 4 Jul 2011 23:07:26 +0200 |
User-agent: |
KMail/1.9.9 |
Hi Jim,
> m4/po.m4
> *** indent with spaces, not TABs;
> ...
> Bruno, I didn't change po.m4, since it's from gettext.
> If you plan to fix it, I'll leave the failure for now.
> Otherwise, let me know and I'll exempt that file, too.
The leading tabs in m4/po.m4 are not indentation, but rather pieces of
Makefiles, and Makefiles need to have lines that start with a tab.
Therefore, please, exempt that file.
> Also, regarding the cpp indentation in stdio-read.c and stdio-write.c,
> would you prefer to exempt those two files or to indent the offending
> #undef directives?
Code like
char *
gets (char *s)
#undef gets
{
...
}
has pretty much become an idiom in gnulib. I'd like to keep it as-is.
Therefore, can you please exempt these two files as well?
Bruno
--
In memoriam Yonatan Netanyahu <http://en.wikipedia.org/wiki/Yonatan_Netanyahu>
- [PATCH] maint: indent with spaces, not TABs, and add a rule to check this, Jim Meyering, 2011/07/04
- Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check this,
Bruno Haible <=
- Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check this, Jim Meyering, 2011/07/05
- Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check this, Bruno Haible, 2011/07/05
- Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check this, Jim Meyering, 2011/07/05
- Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check this, Bruno Haible, 2011/07/07
- Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check this, Jim Meyering, 2011/07/07
Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check this, Jim Meyering, 2011/07/05