bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check


From: Jim Meyering
Subject: Re: [PATCH] maint: indent with spaces, not TABs, and add a rule to check this
Date: Thu, 07 Jul 2011 13:48:15 +0200

Bruno Haible wrote:
> Jim Meyering wrote:
>> > tab=`printf '\t'`
>> >
>> > appears to work. Is it portable?
>>
>> Yes, that is what I would use.
>
> OK, with that, I've removed all tabs from m4/po.m4:

Thanks.
Accordingly, I've done this:

>From 066e4a8d5e927bebebb6dcdea3bdf52ad48a388a Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 7 Jul 2011 13:45:25 +0200
Subject: [PATCH] maint: reduce list of files exempt from
 sc_prohibit_leading_TABs

* Makefile (sc_prohibit_leading_TABs): Don't exempt m4/po.m4,
now that it no longer contains leading TABs.
Remove unused "url=FIXME" statement.
---
 ChangeLog |    7 +++++++
 Makefile  |    3 +--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 4d2b71d..2da7d07 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-07-07  Jim Meyering  <address@hidden>
+
+       maint: reduce list of files exempt from sc_prohibit_leading_TABs
+       * Makefile (sc_prohibit_leading_TABs): Don't exempt m4/po.m4,
+       now that it no longer contains leading TABs.
+       Remove unused "url=FIXME" statement.
+
 2011-07-07  Bruno Haible  <address@hidden>

        Avoid literal tabs.
diff --git a/Makefile b/Makefile
index 4722647..cb1d7cd 100644
--- a/Makefile
+++ b/Makefile
@@ -34,9 +34,8 @@ sc_prefer_ac_check_funcs_once:

 sc_prohibit_leading_TABs:
        if test -d .git; then                                           \
-         url=FIXME;                                                    \
          git grep -l '^ *      ' lib m4 tests                          \
-            | grep -Ev '^m4/po\.m4|^lib/reg|Makefile|test-update-copyright' \
+            | grep -Ev '^lib/reg|Makefile|test-update-copyright'       \
             | grep .                                                   \
            && { printf '*** %s\n' 'indent with spaces, not TABs;'      \
                 1>&2; exit 1; } || :                                   \
--
1.7.6.430.g34be2



reply via email to

[Prev in Thread] Current Thread [Next in Thread]