bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] getopt-gnu: avoid crash in glibc getopt


From: Bruno Haible
Subject: Re: [PATCH] getopt-gnu: avoid crash in glibc getopt
Date: Tue, 19 Jul 2011 21:33:30 +0200
User-agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; )

Eric Blake asked:
> > Does nocrash.m4 prevent core files on Linux, or is it just for
> > preventing modal popup boxes on other OS?

The comments in m4/nocrash.m4 say it:

   ...This is useful to avoid triggering
   action from a background debugger and to avoid core dumps.

Pádraig Brady wrote:
> Note my Fedora system is configured to include pids in the core files,

Hence "rm -f core" in a configure test would be wrong. Hmm, is gnulib is
the only package that has configure tests that may crash, or would it
be useful to move the 'nocrash' module to Autoconf (in the form of an
Autoconf built-in)?

> Attached.

Nearly perfect. Just this code here

             nocrash_init();

             int result = 0;

uses C99 features not in C89 (declaration after statement). Swap these, and
the patch is fine.

Bruno
-- 
In memoriam Paul Schneider 
<http://en.wikipedia.org/wiki/Paul_Schneider_(pastor)>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]