[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bzr-version-gen: New module.

From: Giuseppe Scrivano
Subject: Re: [PATCH] bzr-version-gen: New module.
Date: Sat, 06 Aug 2011 23:16:00 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

Hello Bruno,

Bruno Haible <address@hidden> writes:

> The git-version-gen script has a lot more comments and better error checking.

yes, I know bzr-version-gen is not more than a quick hack.  I hoped than
bringing it upstream in gnulib would attract more users with the same
need who hopefully could also improve it.

> Surely you don't want to duplicate this code? How about, then, merging your
> script with git-version-gen, and rename the module to 'vc-version-gen'?
> (The prefix 'vc' would be consistent with vc-dwim and vc-changelog.)

what about other projects using the git-version-gen module that will
change name?

> The use of $(...) is not portable. Use `...` for portability.
> For more on shell code portability, see the Autoconf manual
> <http://www.gnu.org/software/autoconf/manual/html_node/Portable-Shell.html>
> in particular
> <http://www.gnu.org/software/autoconf/manual/html_node/Shell-Substitutions.html>

Thanks for the suggestion.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]