bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnulib-tool: don't follow dependencies to avoided modules


From: Bruno Haible
Subject: Re: [PATCH] gnulib-tool: don't follow dependencies to avoided modules
Date: Sat, 8 Oct 2011 10:31:10 +0200
User-agent: KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; )

Paul Eggert wrote:
> I used the current Emacs trunk version (bzr 106019).
> 
>   bzr branch bzr://bzr.savannah.gnu.org/emacs/trunk
>   git clone git://git.savannah.gnu.org/gnulib.git
>   cd trunk
>   ./autogen.sh
>   ./configure
>   make sync-from-gnulib

A simplified way to reproduce it, without requiring Emacs sources, is:

  $ ./gnulib-tool --create-testdir --dir=/tmp/testdir \
                  --avoid=msvc-inval --avoid=msvc-nothrow --avoid=pathmax \
                  --avoid=raise --avoid=threadlib \
                  --conditional-dependencies \
                  alloca-opt careadlinkat crypto/md5 crypto/sha1 crypto/sha256 \
                  crypto/sha512 dtoastr dup2 filemode getloadavg getopt-gnu \
                  ignore-value intprops lstat mktime pthread_sigmask readlink \
                  socklen stdarg stdio strftime strtoimax strtoumax symlink \
                  sys_stat

> to save you the time I ran it with your patch, and it worked fine.

Thanks. More precisely, the invocation of the conditional dependencies
is now sorted alphabetically, but since the order of dependencies is
unspecified, it is equivalent.

> Incidentally, I'm seeing a whole lotta output of md5sum in
> gnulib-tool, which I don't understand the reason for -- for
> example, somehow dup2 is turning into some md5 gibberish,

The dup2 dependencies 'msvc-inval' and 'msvc-nothrow' are turned into
f691f076f650964c9f5598c3ee487616 and 676220fa4366efa9bdbfccf11a857c07,
respectively. That's the simplest way I found to create shell function
names from module names, given that module names can contain dashes,
slashes, dollars, and even non-ASCII characters. Of course, one of the
requirements of this mapping from module name to shell function name
is that it should not produce collisions.

Bruno
-- 
In memoriam Engin Ceber <http://en.wikipedia.org/wiki/Engin_Ceber>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]