[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: openat includes
|
From: |
Bruno Haible |
|
Subject: |
Re: openat includes |
|
Date: |
Sat, 5 Nov 2011 10:43:18 +0100 |
|
User-agent: |
KMail/1.13.6 (Linux/2.6.37.6-0.5-desktop; KDE/4.6.0; x86_64; ; ) |
Paul Eggert wrote:
> openat_needs_fchdir -- which is a function that
> openat.c must implement.
If that was the only use of 'bool' in openat.c, I would not have done the
change. But it's also used in line 193.
> In general in my experience it's OK for foo.c to assume
> interfaces provided by foo.h.
Sure. But the interface of openat.c is <fcntl.h>.
openat.h is just an auxiliary include file. You removed the
include <dirent.h> from it yesterday; you may want to remove
include <stdbool.h> from it tomorrow, when refactoring openat_needs_fchdir
in some way.
Bruno
--
In memoriam Bernhard Lichtenberg
<http://en.wikipedia.org/wiki/Bernhard_Lichtenberg>