bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-


From: Eric Blake
Subject: Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length
Date: Tue, 29 Nov 2011 16:53:52 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 11/29/2011 04:50 PM, Bruno Haible wrote:
> Eric Blake wrote:
>> Meanwhile, your patch for adding 'F' is okay
> 
> Why in upper case? The common habit seems to be to use the suffix 'f'
> in lower case but 'L' in upper case. Don't ask me why, but this is the
> way it's done in the vast majority of the glibc sources.

I guess the argument here is that 'f' is easier to type, and still
visually distinct, while 'l' looks too much like '1' so 'L' helps make
the distinction.  Also, %Lg is how you specify long double to printf, so
writing a constant with L helps.

No problem by me if we stick to 'f' and 'L' for the places where we want
suffixes.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]