[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] sethostname handling patch series

From: Bruno Haible
Subject: Re: [RFC] sethostname handling patch series
Date: Thu, 1 Dec 2011 12:29:55 +0100
User-agent: KMail/1.13.6 (Linux/; KDE/4.6.0; x86_64; ; )

Hi Ben,

> The only point I'm not clear on is the note about using a fixed size
> array allocation instead of the dynamic one.  Is it acceptable to use
> HOST_NAME_MAX + 1 to achieve a size that is known to the compiler at
> compile time

Yes. Stack allocations are OK up to a size of ca. 4096. HOST_NAME_MAX
is 64 or 255 or 256 on all known systems, and it wouldn't make sense
to make it longer than 1000.

> Each patch should also update Changlog as well, correct?

Yes, but you can also send the ChangeLog entry separately from the patch
(in the same mail, as a copy&paste), if that's simpler for you.

> I think that
> the patch to add test-sethostname would be best as a fourth patch
> since it can't be used until the unistd integration is done.

Yes, I do it the same way: First the patch that adds new functionality,
then the unit test. Of course, during development, I create both together.
But separating them in the proposal and in the commits makes the review

In memoriam Alfred Herrhausen <http://en.wikipedia.org/wiki/Alfred_Herrhausen>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]