[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-

From: Eric Blake
Subject: Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length
Date: Thu, 01 Dec 2011 14:52:18 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0

On 11/29/2011 02:05 PM, Paul Eggert wrote:
> On 11/29/11 09:35, Jim Meyering wrote:
>> +  gl_WARN_ADD([-Wno-unsuffixed-float-constants])
> How about if we remove -Wunsuffixed-float-constants from
> manywarnings.m4?  In practice it typically causes more
> trouble than it cures (the above-quoted gzip patch is
> one example, but I've run into it elsewhere).
> While we're on the subject of manywarnings.m4, can we also
> remove -Wdouble-promotion and -Wformat-zero-length?  They
> also seem to be more suited for special- rather than
> general-purpose code.

I've just found another problem with the manywarnings module:

gcc 4.6.2 handles -Wabi and -Wdeprecated just fine for C code (I don't
know if it is silently ignored, or if it could actually trigger); but
gcc 4.2.1 (as shipped on FreeBSD) complains:

cc1: warning: command line option "-Wabi" is valid for C++/ObjC++ but
not for C
cc1: warning: command line option "-Wdeprecated" is valid for C++/ObjC++
but not for C

on every single compilation run.  Is there a way to improve the module
so that these warnings are not added to the command line when dealing
with older (noisier) gcc?

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]