[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint.mk: add per-line exclusions to prohibitions

From: Eric Blake
Subject: Re: [PATCH] maint.mk: add per-line exclusions to prohibitions
Date: Thu, 01 Mar 2012 17:20:57 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1

On 03/01/2012 03:20 PM, Jim Meyering wrote:
> Thanks.
> That looks fine, but I haven't tested it.
> However, while reviewing it, I realized that you'll want to adjust
> slightly.  Once I push the following (tomorrow morning), you can
> add an "export exclude =" line of your own.


> Or initialize with "export exclude = ^$$" and simplify this part of your 
> patch:
> -         | grep -vE "$${exclude-^$$}"                                        
> \
> +         | grep -vE "$$exclude"                                      \

Won't work, because then $exclude is always defined to a non-empty
value, but we complain if it both $require and $exclude are non-empty
($require and $prohibit are mutually-exclusive, but $exclude only works
with $prohibit).

>>From 1b98d11e35032bd2ceb1c4a67b66d4655100eeea Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Thu, 1 Mar 2012 23:13:34 +0100
> Subject: [PATCH] maint.mk: avoid spurious failure of _sc_search_regexp-using
>  tests
> * top/maint.mk: Initialize _sc_search_regexp parameters, so that
> envvar settings cannot interfere.  Otherwise, setting envvars like
> prohibit=foo require=bar, etc. would cause spurious test failures.
> ---
>  ChangeLog    |    7 +++++++
>  top/maint.mk |   10 ++++++++++
>  2 files changed, 17 insertions(+)

Actually, I like your patch, so rather than waiting for tomorrow
morning, I went ahead and pushed your patch, along with the
initialization of exclude, after testing things in libvirt.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]