[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: exercise two recently-fixed bugs

From: Paul Eggert
Subject: Re: [PATCH] tests: exercise two recently-fixed bugs
Date: Fri, 16 Mar 2012 16:57:22 -0700
User-agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2

On 03/16/2012 02:50 PM, Jim Meyering wrote:
> the TABs (maybe required in glibc?)

Yes, that's right.  Currently I'm having problems
getting mktime fixes back into glibc, and one of
the issues is that we expanded tabs to spaces.
What a hassle.

> I consider grep's choice of when to use regex vs. DFA to be an
> internal implementation detail, and as such think that its choice
> should not have a significant effect on the output, other than
> a presumed performance improvement when using the DFA matcher.

I suppose we could fix dfa.c to use regex's diagnostics -- they're
accessible I expect.  This'd be another patch, though.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]