[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libvirt] [PATCH 2/4] Fix format specifiers in test cases on Win32

From: Eric Blake
Subject: Re: [libvirt] [PATCH 2/4] Fix format specifiers in test cases on Win32
Date: Thu, 29 Mar 2012 06:45:03 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0

On 03/29/2012 03:53 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <address@hidden>
> Some of the test suites use fprintf with format specifiers
> that are not supported on Win32 and are not fixed by gnulib.
> The mingw32 compiler also has trouble detecting ssize_t
> correctly, complaining that 'ssize_t' does not match
> 'signed size_t' (which it expects for %zd). Force the
> cast to size_t to avoid this problem

Nothing wrong with your libvirt patch, but I can't help wonder if this
is a bug in the gnulib replacement headers, where mingw lacks ssize_t
but gnulib defines it to the wrong type in comparison to size_t (that
is, since mingw64 has sizeof(size_t)==4, it is not obvious whether
size_t is 'unsigned long' or 'unsigned int', and if gnulib picked 'int'
for ssize_t but size_t is 'unsigned long', that would explain the
compiler warnings.  Gnulib may need to be tweaked to help work around
this mingw situation.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]