[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnumakefile: better interaction with Automake-NG
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] gnumakefile: better interaction with Automake-NG |
|
Date: |
Thu, 02 Aug 2012 11:00:05 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 |
On 08/02/2012 10:53 AM, Stefano Lattarini wrote:
> * modules/gnumakefile [Makefile.am]: The makefiles generated by
> Automake-NG always contain a definition of VPATH, even in non-VPATH
> builds (its value being simply '.' in that case). So, in the
> 'clean-GNUmakefile' rule, to determine whether running under a
> VPATH setup, compare '$(srcdir)' to '.' rather than checking whether
> '$(VPATH)' expands to the empty string.
> ---
That fixes things with automake-ng, but what about with existing automake?
> clean-GNUmakefile:
> - test x'$(VPATH)' != x && rm -f $(top_builddir)/GNUmakefile || :
> + test '$(srcdir)' = . || rm -f $(top_builddir)/GNUmakefile
That is, shouldn't this really be:
case '$(srcdir)' in
.|'') ;;
*) rm -f $(top_builddir)/GNUmakefile ;;
esac
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature