[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: extern-inline: be -Wundef safe in config.h

From: Akim Demaille
Subject: Re: extern-inline: be -Wundef safe in config.h
Date: Fri, 28 Sep 2012 09:38:44 +0200

Le 25 sept. 2012 à 16:06, Eric Blake a écrit :

> On 09/25/2012 06:27 AM, Akim Demaille wrote:
>> Recent changes introduce -Wundef warnings in config.h.  The
>> appended proposal eliminates them.
>> -#if __GNUC__ ? __GNUC_STDC_INLINE__ : 199901L <= __STDC_VERSION__
>> +#if (__GNUC__ \
> Even though gcc's -Wundef will never warn about __GNUC__ being
> undefined, it seems like you should also be checking that __GNUC__ is
> defined for the sake of non-gcc compilers, if we accept this approach.

Hi Eric,

there are several places where we have __GNUC__ unprotected,
and AFAICT, it has never been a problem.  In this case, I
do have problems in Bison.

So I don't know if it is worth the trouble.

> At any rate, while most of gnulib doesn't care about -Wundef, I can
> agree to the concept of having config.h be -Wundef clean, so I'm okay
> with this patch if Paul is.

This has already been agreed,

I'm waiting for Paul's opinion here.  Or should I proceed?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]