Re: Problem with new release target in maint.mk

[Eric Blake]

On 10/01/2012 02:03 PM, Reuben Thomas wrote:
> On 1 October 2012 20:37, Jim Meyering <address@hidden> wrote:
>> Reuben Thomas wrote:
>>> I get the following error while trying to make a GNU Zile release:
>>>
>>> /bin/bash: -c: line 1: syntax error near unexpected token `then'
>>> /bin/bash: -c: line 1: address@hidden test -d ../release; then  \'
>>> make[2]: *** [release-prep] Error 1
>>>
>>> I'm using bash 4.2.24(1)-release as shipped with Ubuntu 12.04. /bin/sh
>>> is dash 0.5.7. (I am slightly unclear why the error above is from
>>> bash, not dash…)

Probably because SHELL is set in your makefile to point to /bin/bash
based on what shell configure used, and that in turn is probably because
your /bin/sh (presumably dash) lacked something that configure wanted to
use (the most common problem here is that older dash lacked $LINENO
support).  But you'd have to check your config.log to be sure.


>> release-prep:
>>         $(AM_V_GEN)$(MAKE) --no-print-directory -s announcement \
>>           > ~/announce-$(my_distdir)
>>         $(AM_V_at)if test -d $(release_archive_dir); then       \
>>           ln $(rel-files) $(release_archive_dir);               \
>>           chmod a-w $(rel-files);                               \
>>         fi
> 
> I don't think it can be that, because that's not line 1.

Yes it is.  Remember that in make, each line that is not a continuation
of the previous line is fed to a new '$SHELL -c' instance, and
therefore, there are TWO 'line 1' locations within the release-prep
rule, because there are two shells spawned.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature