[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ptsname: reject invalid file descriptors
From: |
Eric Blake |
Subject: |
Re: [PATCH] ptsname: reject invalid file descriptors |
Date: |
Tue, 02 Oct 2012 20:42:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 |
On 10/02/2012 12:31 PM, Eric Blake wrote:
> POSIX left errno undefined on ptsname() failure, although there
> has at least been an effort to specify reasonable values to use:
> http://www.austingroupbugs.net/view.php?id=503
>
> However, our tests for ptsname and ptsname_r already require errno
> to be set to useful values (as in glibc), so it is worth replacing
> ptsname on FreeBSD 8.2 in order to get better QoI and pass the test.
>
> * m4/ptsname.m4 (gl_FUNC_PTSNAME): Probe for FreeBSD bug.
> * m4/stdlib_h.m4 (gl_STDLIB_H_DEFAULTS): Add new witness.
> * modules/stdlib (Makefile.am): Replace witness.
> * lib/stdlib.in.h (ptsname): Allow for replacement.
> * modules/ptsname (configure.ac): Trigger replacement.
> * doc/posix-functions/ptsname.texi (ptsname): Document this.
Unfortunately, while this fixed test-ptsname, it shows up now as a
failure in test-posix_openpt on FreeBSD. I'm still investigating.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature