[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [virt-tools-list] [libosinfo v4 3/3] Mark obvious strings in DB for

From: Eric Blake
Subject: Re: [virt-tools-list] [libosinfo v4 3/3] Mark obvious strings in DB for translation
Date: Fri, 26 Oct 2012 09:55:14 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1

[adding gnulib]

On 10/25/2012 08:20 PM, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <address@hidden>
> Mark 'name' and 'vendor' in oses and hypervisor, and 'name' in devices
> for translation.
> This implies that now we generate the actual XML files to automatically
> get translations inserted into them.
> Note that this break `make syntax-check` because sc_po_check rule in
> maint.mk doesn't know how deal with xml.in files and I got a headache
> trying to correct this in the magic shell script.

I see the problem: gnulib's maint.mk hard-codes the check for files that
contain translatable strings according to C rules, with this regex
buried in sc_po_check:

          grep -E -l '\b(N?_|gettext *)\([^)"]*("|$$)' $$files          \

But for libosinfo, where we are translating strings in XML, the intltool
recommendations are to mark those strings with a different pattern:

> -    <vendor>LSI Logic / Symbios Logic</vendor>
> +    <_vendor>LSI Logic / Symbios Logic</_vendor>

So either the gnulib regex needs to be globally loosened to also
recognize the XML markup, or better, needs to be made configurable and
then libosinfo's cfg.mk can reconfigure the string to recognize the
additional pattern (basically, it looks like the pattern <_ is the magic
markup string in XML files).

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]