[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint.mk: get current gnulib revision correctly.
From: |
Jim Meyering |
Subject: |
Re: [PATCH] maint.mk: get current gnulib revision correctly. |
Date: |
Mon, 28 Oct 2013 16:10:05 -0700 |
On Mon, Oct 28, 2013 at 8:45 AM, Bruce Korb <address@hidden> wrote:
> On 10/27/13 17:46, Pádraig Brady wrote:
>>>
>>> gnulib_dir ?= $(srcdir)/gnulib
>>> -gnulib-version = $$(cd $(gnulib_dir) && git describe)
>>> +gnulib-version = $$(cd $(gnulib_dir) && git rev-parse --short HEAD)
>>> bootstrap-tools ?= autoconf,automake,gnulib
>
> ...
>
>> This would change the announce message from:
>> Gnulib v0.0-7848-g4a82904
>> to:
>> Gnulib 4a82904
>
>
> That, or "/path/to/gnulib\nGnulib 4a82904"
> I'd suggest:
> gnulib-version = $$(cd $(gnulib_dir) >/dev/null && git rev-parse --short
> HEAD)
Thanks for the suggestion, Bruce.
However, I prefer not to change every use of
"cd"-in-subshell-where-stdout-matters.
That is too hard to maintain. Instead, I'll do this:
k.txt
Description: Text document