[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix dummy module being included even when not needed

From: Eric Blake
Subject: Re: [PATCH] Fix dummy module being included even when not needed
Date: Fri, 08 Nov 2013 08:11:53 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 11/07/2013 11:14 AM, Benjamin Cama wrote:
> The test was inverted.
> Signed-off-by: Benjamin Cama <address@hidden>
> ---
>  gnulib-tool |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> diff --git a/gnulib-tool b/gnulib-tool
> index 669931c..55fbee3 100755
> --- a/gnulib-tool
> +++ b/gnulib-tool
> @@ -2954,7 +2954,7 @@ ba
>      fi
>    done
>    # Add the dummy module, to make sure the library will be non-empty.
> -  if test -z "$have_lib_SOURCES"; then
> +  if test -n "$have_lib_SOURCES"; then
>      if func_acceptable "dummy"; then
>        func_append modules " dummy"

Huh?  The existing code seems correct - if there were no other
lib_SOURCES (the variable is empty), then we need to add dummy so that
we have at least one lib source.  Your patch would change it so that if
there are lib_SOURCES, then we also include dummy.  I think I need a bit
more context why your patch would be correct.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]