locale test failures on illumos

[Pádraig Brady]

On 15/01/15 18:05, Alexander Pyhalov wrote:
> Hello.

> test-locale.c. It assumes that LC_GLOBAL_LOCALE is a constant.
> On illumos it's a function, so compilation fails. Fix is here:
https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/coreutils/patches/gnulib-tests_test-locale.c.patch

This looks good, though it would be preferable to combine with a fix for...

> [test-getlogin] uses gl_locale_name_thread_unsafe, which simply doesn't know 
> about
> illumos/Solaris and returns NULL, so the test fails.

Does querylocale() exist for __sun ?
Perhaps it's just a matter of adding __sun to the elif define
in gl_locale_name_thread_unsafe() ?

Or perhaps this is (also) due to LC_GLOBAL_LOCALE being
a function on illumos, in which case it would need to
be assigned to a local variable before the comparison.

thanks,
Pádraig.