bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [libvirt] [PATCH] util: Fix build on s390


From: Eric Blake
Subject: Re: [libvirt] [PATCH] util: Fix build on s390
Date: Thu, 13 Oct 2016 08:36:54 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 10/07/2016 05:43 AM, Jiri Denemark wrote:
> GCC on s390 complains
> 
> util/virconf.c: In function 'virConfGetValueSizeT':
> util/virconf.c:1220:9: error: format '%zu' expects argument of type
> 'size_t', but argument 9 has type 'unsigned int' [-Werror=format=]
> 

That's a bug in s390's system headers.  Gnulib should be taught to work
around it.

> Signed-off-by: Jiri Denemark <address@hidden>
> ---
>  src/util/virconf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/util/virconf.c b/src/util/virconf.c
> index 3e49f41..1372389 100644
> --- a/src/util/virconf.c
> +++ b/src/util/virconf.c
> @@ -1219,7 +1219,7 @@ int virConfGetValueSizeT(virConfPtr conf,
>      if (((unsigned long long)cval->l) > SIZE_MAX) {
>          virReportError(VIR_ERR_INTERNAL_ERROR,
>                         _("%s: value for '%s' parameter must be in range 
> 0:%zu"),
> -                       conf->filename, setting, SIZE_MAX);
> +                       conf->filename, setting, (size_t) SIZE_MAX);
>          return -1;
>      }
>  #endif
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]