bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: getprogname: comments and test failure on Cygwin


From: Pádraig Brady
Subject: Re: getprogname: comments and test failure on Cygwin
Date: Sun, 16 Oct 2016 13:15:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0

On 16/10/16 12:55, Bruno Haible wrote:
> Hi,
> 
> The 'getprogname' module test fails on Cygwin 2.6, because the returned
> value is "test-getprogname", not "test-getprogname.exe". (On mingw, on the
> other hand, it really is "test-getprogname.exe".)
> 
> Also, while at it, I'd like to add comments:
> 1. The declaration in getprogname.h does not state what the function does
>    or return.
> 2. In getprogname.c it is hard to understand which code is used for which
>    platform.
> 3. In test-getprogname.c there is no explanation why the file name is compared
>    with strcmp and not strcasecmp.

All improvements look good to me.

thanks,
Pádraig.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]