[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] fix wrong -Wno-missing-field-initializers detection
From: |
Pádraig Brady |
Subject: |
Re: [PATCH] fix wrong -Wno-missing-field-initializers detection |
Date: |
Wed, 9 Nov 2016 17:04:07 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/11/16 11:21, Frediano Ziglio wrote:
> The small code in m4/manywarnings.m4 wrongly detects if
> -Wno-missing-field-initializers is needed. This happens if
> -Wunused-variable is set. In this case the code fails to compile
> due to -Werror even if -Wno-missing-field-initializers would be
> perfectly fine.
> ---
> m4/manywarnings.m4 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4
> index 89fd0ae..4f701f4 100644
> --- a/m4/manywarnings.m4
> +++ b/m4/manywarnings.m4
> @@ -62,10 +62,11 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC],
> CFLAGS="$CFLAGS -W -Werror"
> AC_COMPILE_IFELSE(
> [AC_LANG_PROGRAM(
> - [[void f (void)
> + [[int f (void)
> {
> typedef struct { int a; int b; } s_t;
> s_t s1 = { 0, };
> + return s1.b;
> }
> ]],
> [[]])],
>
looks good to me.
Pushed
thanks!
Pádraig