bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maintainer-makefiles: provide AC_PROG_SED for older autoconf


From: Bruno Haible
Subject: Re: [PATCH] maintainer-makefiles: provide AC_PROG_SED for older autoconf
Date: Sat, 25 Feb 2017 22:56:14 +0100
User-agent: KMail/5.1.3 (Linux/4.4.0-64-generic; KDE/5.18.0; x86_64; ; )

Eric Blake wrote in
<https://lists.gnu.org/archive/html/bug-gnulib/2014-02/msg00025.html>:

> * m4/gnulib-common.m4 (AC_PROG_SED): Copy from newer autoconf.

There's a misuse of AC_CACHE_CHECK here: when a config.cache is in use,
the second time the test is run (in a different configure run), the variable
SED is not set.

This fixes it. (Although I doubt that it affects many users by now.)


2017-02-25  Bruno Haible  <address@hidden>

        maintainer-makefile: Fix AC_PROG_SED with autoconf cache.
        * m4/gnulib-common.m4 (AC_PROG_SED): Fix AC_CACHE_CHECK invocation.

diff --git a/m4/gnulib-common.m4 b/m4/gnulib-common.m4
index 7d9b40b..7b957f8 100644
--- a/m4/gnulib-common.m4
+++ b/m4/gnulib-common.m4
@@ -1,4 +1,4 @@
-# gnulib-common.m4 serial 36
+# gnulib-common.m4 serial 37
 dnl Copyright (C) 2007-2017 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -456,7 +456,9 @@ m4_ifndef([AC_PROG_SED],
      else
        ac_cv_path_SED=$SED
      fi
+    ])
  SED="$ac_cv_path_SED"
  AC_SUBST([SED])dnl
  rm -f conftest.sed
-])])])
+])
+])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]