[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: stdioext OpenVMS patch.

From: John E. Malmberg
Subject: Re: stdioext OpenVMS patch.
Date: Mon, 3 Jul 2017 08:45:26 -0500
User-agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0

On 7/1/2017 7:47 PM, Bruno Haible wrote:
Hi John,

On OpenVMS, the struct _iobuf is needed to access members of the struct

This is a patch for the affected stdioext modules to compile on OpenVMS.

The approach looks generally right, but I'd request a couple of changes
before this can go in:

>    * Instead of defining a variable 'stream', please using the same
>      coding style as for the other platforms: use macro fp_ which
>      is defined to a cast expression through lib/stdio-impl.h.

Thank you.  That greatly simplifies the updated attached patch.

   * Is _IOERR defined on OpenVMS? In some files, you treat OpenVMS
     as part of the _IOERR case, in others you do it before _IOERR. Which
     is not consistent.
     If _IOERR is defined on OpenVMS, please update all
       #elif defined _IOERR                /* AIX, HP-UX, IRIX, OSF/1, Solaris, 
mingw, MSVC, NonStop Kernel */
     lines to include OpenVMS at the end of the comment.


   * The fbufmode.c change has a regression for all non-Windows, non-OpenVMS

Reverted back to original code.

   * The freading.c change is misindented.

No longer applicable.


Attachment: 0001-stdio.ext-Port-to-OpenVMS_2.patch.gz
Description: GNU Zip compressed data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]