[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 0001-glob-simplify-symlink-detection.patch

From: Paul Eggert
Subject: Re: 0001-glob-simplify-symlink-detection.patch
Date: Sat, 2 Sep 2017 04:17:33 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

Bruno Haible wrote:
Such precautions are not needed, because
   - gnulib for sure will not be ported to architectures where no
     8-bit integer type exists.

Although that's true for much of Gnulib, many Gnulib modules would work just fine on such hosts.

   - Whether C99 requires it or not, does not matter here: The 'glob'
     module depends on 'stdint', and the 'stdint' module provides
     uint8_t unconditionally (for several years already).

gl_STDINT_H's tests of uint8_t all depend on UINT8_MAX being defined, which is not true on hosts lacking uint8_t, so stdint won't provide uint8_t merely because a standard-conforming stdint.h lacks uint8_t. At least, that's the intent of gl_STDINT_H.

Admittedly this issue is pretty esoteric nowadays.

We could finesse all this by simply using char instead of uint8_t, since the values in question are all in the range 0..127 on all platforms we know about.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]